Fix initialization order of isClosed_ in EtwTracer

Author: beep-boopp

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "cmake.sourceDirectory": "/wsl.localhost/Ubuntu/home/percy/opentelemetry-cpp"
+}

exporters/etw/include/opentelemetry/exporters/etw/etw_tracer.h

@@ -185,21 +185,14 @@ class Tracer : public opentelemetry::trace::Tracer,
   /**
    * @brief Provider Handle
    */
-  //change made in pr 
-  // ETWProvider::Handle &provHandle;
-
-  // opentelemetry::trace::TraceId traceId_;
-
-  // std::atomic<bool> isClosed_{true};
-
-  // Fix: Declare isClosed_ before provHandle so it initializes to true 
-  // *before* initProvHandle() runs.
-  std::atomic<bool> isClosed_{true}; 
-
+  // Order matters: isClosed_ must initialize to true BEFORE provHandle 
+  // runs its initialization logic.
+  std::atomic<bool> isClosed_{true};
   ETWProvider::Handle &provHandle;
   opentelemetry::trace::TraceId traceId_;
 
   /**
+   * @brief ETWProvider is a singleton that aggregates all ETW writes.
    * @brief ETWProvider is a singleton that aggregates all ETW writes.
    * @return
    */

exporters/etw/test/etw_tracer_test.cc

@@ -568,17 +568,12 @@ TEST(ETWTracer, EndWithCustomTime)
 
 TEST(ETWTracer, ConstructorInitializesToOpenState)
 {
-  // Setup - Create a mock/real provider dependency
   etw::TracerProvider provider;
   std::string providerId = "TestProvider";
-
-  // Instantiate the Tracer
-  // This triggers the constructor -> initProvHandle sequence
+  
   opentelemetry::exporter::etw::Tracer tracer(provider, providerId);
-
-  //  Verify the Bug Fix
-  // Because we added the 'friend' line in the header, we can access isClosed_ directly.
-  // It should be FALSE (Open) now. Before your fix, this was TRUE.
+  
+  // Tracer should be open after construction
   EXPECT_FALSE(tracer.isClosed_);
 }