Code review comments, enum naming

Author: marcalff

sdk/include/opentelemetry/sdk/configuration/otlp_file_push_metric_exporter_configuration.h

@@ -29,8 +29,9 @@ class OtlpFilePushMetricExporterConfiguration : public PushMetricExporterConfigu
   }
 
   std::string output_stream;
-  enum_temporality_preference temporality_preference{cumulative};
-  enum_default_histogram_aggregation default_histogram_aggregation{explicit_bucket_histogram};
+  TemporalityPreference temporality_preference{TemporalityPreference::cumulative};
+  DefaultHistogramAggregation default_histogram_aggregation{
+      DefaultHistogramAggregation::explicit_bucket_histogram};
 };
 
 }  // namespace configuration

sdk/include/opentelemetry/sdk/configuration/otlp_grpc_push_metric_exporter_configuration.h

@@ -38,8 +38,9 @@ class OtlpGrpcPushMetricExporterConfiguration : public PushMetricExporterConfigu
   std::string compression;
   std::size_t timeout{0};
   bool insecure{false};
-  enum_temporality_preference temporality_preference{cumulative};
-  enum_default_histogram_aggregation default_histogram_aggregation{explicit_bucket_histogram};
+  TemporalityPreference temporality_preference{TemporalityPreference::cumulative};
+  DefaultHistogramAggregation default_histogram_aggregation{
+      DefaultHistogramAggregation::explicit_bucket_histogram};
 };
 
 }  // namespace configuration

sdk/include/opentelemetry/sdk/configuration/otlp_http_push_metric_exporter_configuration.h

@@ -38,9 +38,10 @@ class OtlpHttpPushMetricExporterConfiguration : public PushMetricExporterConfigu
   std::string headers_list;
   std::string compression;
   std::size_t timeout{0};
-  enum_otlp_http_encoding encoding{protobuf};
-  enum_temporality_preference temporality_preference{cumulative};
-  enum_default_histogram_aggregation default_histogram_aggregation{explicit_bucket_histogram};
+  OtlpHttpEncoding encoding{OtlpHttpEncoding::protobuf};
+  TemporalityPreference temporality_preference{TemporalityPreference::cumulative};
+  DefaultHistogramAggregation default_histogram_aggregation{
+      DefaultHistogramAggregation::explicit_bucket_histogram};
 };
 
 }  // namespace configuration

sdk/include/opentelemetry/sdk/configuration/temporality_preference.h

@@ -13,7 +13,9 @@ namespace sdk
 namespace configuration
 {
 
-enum enum_temporality_preference : std::uint8_t
+// YAML-SCHEMA: schema/meter_provider.json
+// YAML-NODE: ExporterTemporalityPreference
+enum class TemporalityPreference : std::uint8_t
 {
   cumulative,
   delta,