Skip to content

Make GetSpan return a statically allocated invalid span #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Make GetSpan return a statically allocated invalid span #3037

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61bea77
Make GetSpan return a statically allocated invalid span
michaelvanstraten Aug 18, 2024
93bfdb0
Merge branch 'main' into make-get_span-return-static-invalid
lalitb Aug 27, 2024
7ff6178
Merge branch 'main' into make-get_span-return-static-invalid
lalitb Oct 9, 2024
1de2123
Merge branch 'main' into make-get_span-return-static-invalid
lalitb Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion api/include/opentelemetry/trace/context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ inline nostd::shared_ptr<Span> GetSpan(const context::Context &context) noexcept
{
return nostd::get<nostd::shared_ptr<Span>>(span);
}
return nostd::shared_ptr<Span>(new DefaultSpan(SpanContext::GetInvalid()));

static thread_local nostd::shared_ptr<Span> invalid_span =
nostd::shared_ptr<Span>(new DefaultSpan(SpanContext::GetInvalid()));
return invalid_span;
}

inline bool IsRootSpan(const context::Context &context) noexcept
Expand Down
Loading