Skip to content

Update CMakeLists.txt - Check protobuf abseil dependency only when there is no CMAKE_TOOLCHAIN_FILE) #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update CMakeLists.txt - Check protobuf abseil dependency only when there is no CMAKE_TOOLCHAIN_FILE) #3048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35c1d14
Update CMakeLists.txt - Check protobuf abseil dependency only when th…
meastp Sep 4, 2024
80be9d9
Update CMakeLists.txt
meastp Sep 4, 2024
bd2d0bc
Update CMakeLists.txt
meastp Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,9 @@ if(WITH_OTLP_GRPC
OR WITH_OTLP_HTTP
OR WITH_OTLP_FILE)
find_package(Protobuf)
if(Protobuf_VERSION AND Protobuf_VERSION VERSION_GREATER_EQUAL "3.22.0")
if(Protobuf_VERSION
AND Protobuf_VERSION VERSION_GREATER_EQUAL "3.22.0"
AND (NOT DEFINED CMAKE_TOOLCHAIN_FILE))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owent mentioned, WITH_ABSEIL is needed even CMAKE_TOOLCHAIN_FILE is defined (like vcpkg is used).

Does this fix the issue? I think we need more details on it.

if(NOT WITH_ABSEIL)
message(
FATAL_ERROR
Expand Down
Loading