-
Notifications
You must be signed in to change notification settings - Fork 509
[EXPORTER] Add config options to prometheus exporter #3104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] Add config options to prometheus exporter #3104
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3104 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
359f751 to
19d20cf
Compare
lalitb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
marcalff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Please fix minor comments on the code flow.
Will approve after that.
012384a to
618f850
Compare
|
Thanks for the reviews! I made the requested changes. I sometimes find double negatives in if conditions a little unreadable, hopefully the small comments on top would make things clear. |
marcalff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Fixes #2453
Changes
Added the following optional configuration options (booleans) to the prometheus exporter:
without_units: controls whether to add unit suffixes (e.g._seconds) to the metric names.without_type_suffix: controls whether to add type suffixes (e.g._total) to the metric names.CHANGELOG.mdupdated for non-trivial changes