-
Notifications
You must be signed in to change notification settings - Fork 500
[SEMANTIC CONVENTIONS] Migration to weaver #3105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcalff
merged 25 commits into
open-telemetry:main
from
marcalff:migrate_semconv_weaver
Nov 13, 2024
Merged
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8eabd8a
Migration to weaver - work in progress
marcalff d289a7f
WIP
marcalff d880a1a
CI cleanup
marcalff 5308cc2
Removed attributes directory
marcalff 5fb6486
Format
marcalff 88c22c8
Merge branch 'main' into migrate_semconv_weaver
marcalff c427131
added metrics (draft)
marcalff 96a954f
Merge branch 'main' into migrate_semconv_weaver
marcalff 0642e24
Metrics, continued.
marcalff 92eb5b0
Merge branch 'main' into migrate_semconv_weaver
marcalff 4304b40
Merge branch 'main' into migrate_semconv_weaver
marcalff bdef3df
cleanup
marcalff 0d56601
cleanup
marcalff 8472ddb
cleanup
marcalff 0653c7a
code cleanup
marcalff 07e0e67
Merge branch 'main' into migrate_semconv_weaver
marcalff e3f02d2
Merge branch 'main' into migrate_semconv_weaver
marcalff d459cd5
Merge branch 'main' into migrate_semconv_weaver
marcalff 975ba9c
Merge branch 'main' into migrate_semconv_weaver
marcalff a47ff20
Deprecation, changelog.
marcalff 2237416
Markdown cleanup
marcalff 4b86725
Merge branch 'main' into migrate_semconv_weaver
marcalff 3a42cd4
Set deprecation date.
marcalff 1077265
Implemented code review comments.
marcalff d125af2
Fixed gauges.
marcalff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
/* | ||
* DO NOT EDIT, this is an Auto-generated file from: | ||
* buildscripts/semantic-convention/templates/registry/semantic_attributes-h.j2 | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include "opentelemetry/common/macros.h" | ||
#include "opentelemetry/version.h" | ||
|
||
OPENTELEMETRY_BEGIN_NAMESPACE | ||
namespace semconv | ||
{ | ||
namespace client | ||
{ | ||
|
||
/** | ||
* Client address - domain name if available without reverse DNS lookup; otherwise, IP address or | ||
* Unix domain socket name. <p> When observed from the server side, and when communicating through | ||
* an intermediary, @code client.address @endcode SHOULD represent the client address behind any | ||
* intermediaries, for example proxies, if it's available. | ||
*/ | ||
static constexpr const char *kClientAddress = "client.address"; | ||
|
||
/** | ||
* Client port number. | ||
* <p> | ||
* When observed from the server side, and when communicating through an intermediary, @code | ||
* client.port @endcode SHOULD represent the client port behind any intermediaries, for example | ||
* proxies, if it's available. | ||
*/ | ||
static constexpr const char *kClientPort = "client.port"; | ||
|
||
} // namespace client | ||
} // namespace semconv | ||
OPENTELEMETRY_END_NAMESPACE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
/* | ||
* DO NOT EDIT, this is an Auto-generated file from: | ||
* buildscripts/semantic-convention/templates/registry/semantic_attributes-h.j2 | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include "opentelemetry/common/macros.h" | ||
#include "opentelemetry/version.h" | ||
|
||
OPENTELEMETRY_BEGIN_NAMESPACE | ||
namespace semconv | ||
{ | ||
namespace error | ||
{ | ||
|
||
/** | ||
* Describes a class of error the operation ended with. | ||
* <p> | ||
* The @code error.type @endcode SHOULD be predictable, and SHOULD have low cardinality. | ||
* <p> | ||
* When @code error.type @endcode is set to a type (e.g., an exception type), its | ||
* canonical class name identifying the type within the artifact SHOULD be used. | ||
* <p> | ||
* Instrumentations SHOULD document the list of errors they report. | ||
* <p> | ||
* The cardinality of @code error.type @endcode within one instrumentation library SHOULD be low. | ||
* Telemetry consumers that aggregate data from multiple instrumentation libraries and applications | ||
* should be prepared for @code error.type @endcode to have high cardinality at query time when no | ||
* additional filters are applied. | ||
* <p> | ||
* If the operation has completed successfully, instrumentations SHOULD NOT set @code error.type | ||
* @endcode. <p> If a specific domain defines its own set of error identifiers (such as HTTP or gRPC | ||
* status codes), it's RECOMMENDED to: <p> <ul> <li>Use a domain-specific attribute</li> <li>Set | ||
* @code error.type @endcode to capture all errors, regardless of whether they are defined within | ||
* the domain-specific set or not.</li> | ||
* </ul> | ||
*/ | ||
static constexpr const char *kErrorType = "error.type"; | ||
|
||
namespace ErrorTypeValues | ||
{ | ||
/** | ||
* A fallback error value to be used when the instrumentation doesn't define a custom value. | ||
*/ | ||
static constexpr const char *kOther = "_OTHER"; | ||
|
||
} // namespace ErrorTypeValues | ||
|
||
} // namespace error | ||
} // namespace semconv | ||
OPENTELEMETRY_END_NAMESPACE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Copyright The OpenTelemetry Authors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
/* | ||
* DO NOT EDIT, this is an Auto-generated file from: | ||
* buildscripts/semantic-convention/templates/registry/semantic_attributes-h.j2 | ||
*/ | ||
|
||
#pragma once | ||
|
||
#include "opentelemetry/common/macros.h" | ||
#include "opentelemetry/version.h" | ||
|
||
OPENTELEMETRY_BEGIN_NAMESPACE | ||
namespace semconv | ||
{ | ||
namespace exception | ||
{ | ||
|
||
/** | ||
* SHOULD be set to true if the exception event is recorded at a point where it is known that the | ||
* exception is escaping the scope of the span. <p> An exception is considered to have escaped (or | ||
* left) the scope of a span, if that span is ended while the exception is still logically "in | ||
* flight". This may be actually "in flight" in some languages (e.g. if the exception is passed to a | ||
* Context manager's @code __exit__ @endcode method in Python) but will usually be caught at the | ||
* point of recording the exception in most languages. <p> It is usually not possible to determine | ||
* at the point where an exception is thrown whether it will escape the scope of a span. However, it | ||
* is trivial to know that an exception will escape, if one checks for an active exception just | ||
* before ending the span, as done in the <a | ||
* href="https://opentelemetry.io/docs/specs/semconv/exceptions/exceptions-spans/#recording-an-exception">example | ||
* for recording span exceptions</a>. <p> It follows that an exception may still escape the scope of | ||
* the span even if the @code exception.escaped @endcode attribute was not set or set to false, | ||
* since the event might have been recorded at a time where it was not | ||
* clear whether the exception will escape. | ||
*/ | ||
static constexpr const char *kExceptionEscaped = "exception.escaped"; | ||
|
||
/** | ||
* The exception message. | ||
*/ | ||
static constexpr const char *kExceptionMessage = "exception.message"; | ||
|
||
/** | ||
* A stacktrace as a string in the natural representation for the language runtime. The | ||
* representation is to be determined and documented by each language SIG. | ||
*/ | ||
static constexpr const char *kExceptionStacktrace = "exception.stacktrace"; | ||
|
||
/** | ||
* The type of the exception (its fully-qualified class name, if applicable). The dynamic type of | ||
* the exception should be preferred over the static type in languages that support it. | ||
*/ | ||
static constexpr const char *kExceptionType = "exception.type"; | ||
|
||
} // namespace exception | ||
} // namespace semconv | ||
OPENTELEMETRY_END_NAMESPACE |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.