[EXPORTER] Elastic Search exporter follow ECS guidelines #3107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
ShadowMaxLeb
force-pushed
the
elastic-exporter-els-format
branch
2 times, most recently
from
c295345 to
67d7e6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3107 +/- ##
==========================================
+ Coverage 87.12% 87.91% +0.79%
==========================================
Files 200 195 -5
Lines 6109 6133 +24
==========================================
+ Hits 5322 5391 +69
+ Misses 787 742 -45 |
`body` According to ECS logging reference https://www.elastic.co/guide/en/ecs/8.11/ecs-base.html#field-message Refs open-telemetry#3091
…ad of
`severity`
According to ECS logging reference
https://www.elastic.co/guide/en/ecs/8.11/ecs-log.html#field-log-level
Refs open-telemetry#3091
`timestamp` Also changes the format to be a Date string. According to ECS logging reference https://www.elastic.co/guide/en/ecs/8.11/ecs-base.html#field-timestamp Refs open-telemetry#3091
…ger` instead of `name` According to ECS logging reference https://www.elastic.co/guide/en/ecs/8.11/ecs-log.html#field-log-logger Refs open-telemetry#3091
…ield to 8.11.0 According to ECS guidelines this field is mandatory https://www.elastic.co/guide/en/ecs/8.11/ecs-guidelines.html Refs open-telemetry#3091
`attributes` This allows user to set other fields that are part of the [ECS log documentation](https://www.elastic.co/guide/en/ecs/8.11/ecs-log.html). For instance, it allows to have an attribute with key `log.file`, that will, thanks to `nlohmann::json`, appear as : ``` { "log": { "file": "xxx" } } ``` Closes open-telemetry#3091
ShadowMaxLeb
force-pushed
the
elastic-exporter-els-format
branch
from
27eadab to
6d72624
Compare
marcalff
changed the title
owent
approved these changes
Oct 22, 2024
|
Thanks for the fix. @ShadowMaxLeb Please merge main into this PR, to resolve "This branch is out-of-date with the base branch". |
marcalff
added
the
ok-to-merge
lalitb
approved these changes
Oct 23, 2024
I will try to update it next week as I cannot do it right now. |
|
@marcalff , How can I retry the failed job as it failed because it was lacking a runner ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3091
Changes
Try to follow as much as possible the ECS guidelines and the ECS Logs reference
This impacts fields:
Datestringmessagelog.loggerlog.levelattributeskey anymore