Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 22, 2024

Fix missing dependency on protoc compiler.

Changes

Please provide a brief description of the changes here.

  • When generating protoc dependent code, add a dependency on the compiler itself.
  • This is important to make sure the correct code is generated again, in case of protoc upgrade or downgrade since a previous build.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 1465c6b
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/674106de97f17b0008968679

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (f1b5fbd) to head (1465c6b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3159   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747           
---- 🚨 Try these New Features:

@marcalff marcalff marked this pull request as ready for review November 22, 2024 11:35
@marcalff marcalff requested a review from a team as a code owner November 22, 2024 11:35
@marcalff marcalff added the pr:please-review This PR is ready for review label Nov 22, 2024
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@marcalff marcalff merged commit 09c0616 into open-telemetry:main Nov 22, 2024
57 checks passed
@marcalff marcalff deleted the fix_proto_compiler branch February 5, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants