Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 25, 2024

Fixes #3145

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for opentelemetry-cpp-api-docs ready!

Name Link
🔨 Latest commit 7a7919a
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6744eea54bab8800087d5c54
😎 Deploy Preview https://deploy-preview-3168--opentelemetry-cpp-api-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcalff marcalff added the pr:please-review This PR is ready for review label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (2a8c8bc) to head (7a7919a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
- Coverage   87.86%   87.84%   -0.01%     
==========================================
  Files         195      195              
  Lines        6151     6151              
==========================================
- Hits         5404     5403       -1     
- Misses        747      748       +1     

see 1 file with indirect coverage changes

@marcalff marcalff marked this pull request as ready for review November 25, 2024 21:53
@marcalff marcalff requested a review from a team as a code owner November 25, 2024 21:53
@marcalff marcalff merged commit 955a807 into open-telemetry:main Nov 25, 2024
57 checks passed
@marcalff marcalff deleted the release_1.18 branch February 5, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RELEASE] Prepare release opentelemetry-cpp 1.18.0

2 participants