Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 17, 2024

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Use opentelemetry-collector 0.115.1 in functional tests, as 0.116.0 fails.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit eced4c6
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6761e36ee6053b00088c3124

@marcalff
Copy link
Member Author

marcalff commented Dec 17, 2024

CI in the opentelemetry-cpp repository started to fail on functional tests 4 hours ago, even when it was passing for the same commit earlier.

opentelemetry-collector released v0.116.0 4 hours ago.

See related:

@marcalff marcalff changed the title Use collector v0.115.1 [TEST] Use collector v0.115.1 in functional tests Dec 17, 2024
@marcalff marcalff marked this pull request as ready for review December 17, 2024 20:58
@marcalff marcalff requested a review from a team as a code owner December 17, 2024 20:58
@marcalff marcalff added issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review labels Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (902ee88) to head (eced4c6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3213      +/-   ##
==========================================
- Coverage   87.83%   87.82%   -0.01%     
==========================================
  Files         195      195              
  Lines        6154     6154              
==========================================
- Hits         5405     5404       -1     
- Misses        749      750       +1     

see 1 file with indirect coverage changes

@marcalff
Copy link
Member Author

It seems opentelemetry-collector now released a 0.116.1 docker image, and CI using latest is picking it up and passes.

@marcalff
Copy link
Member Author

Closing, resolved by new opentelemetry-collector docker image 0.116.1

@marcalff marcalff closed this Dec 17, 2024
@marcalff marcalff deleted the fix_func_ubuntu branch February 5, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant