Skip to content

[SDK] Optimize Metric Processing for Single Collector with Delta Temporality #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2025
Merged

[SDK] Optimize Metric Processing for Single Collector with Delta Temporality #3236

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
983162b
initial commit
lalitb Jan 9, 2025
8f60276
Merge branch 'main' into single-collector-delta-fastpath
ThomsonTan Jan 21, 2025
03efcb5
review comments
lalitb Jan 22, 2025
822861b
revert
lalitb Jan 22, 2025
24ab035
format
lalitb Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions sdk/src/metrics/state/temporal_metric_storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,36 @@ bool TemporalMetricStorage::buildMetrics(CollectorHandle *collector,
AggregationTemporality aggregation_temporarily =
collector->GetAggregationTemporality(instrument_descriptor_.type_);

// Fast path for single collector with delta temporality and counter, updown-counter, histogram
if (collectors.size() == 1 && collector->GetAggregationTemporality(
instrument_descriptor_.type_) == AggregationTemporality::kDelta)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: use the aggregation_temporarily local variable, from the previous line, in the if test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks done.

{
// If no metrics, early return
if (delta_metrics->Size() == 0)
{
return true;
}

// Create MetricData directly
MetricData metric_data;
metric_data.instrument_descriptor = instrument_descriptor_;
metric_data.aggregation_temporality = AggregationTemporality::kDelta;
metric_data.start_ts = sdk_start_ts;
metric_data.end_ts = collection_ts;

// Direct conversion of delta metrics to point data
delta_metrics->GetAllEnteries(
[&metric_data](const MetricAttributes &attributes, Aggregation &aggregation) {
PointDataAttributes point_data_attr;
point_data_attr.point_data = aggregation.ToPoint();
point_data_attr.attributes = attributes;
metric_data.point_data_attr_.emplace_back(std::move(point_data_attr));
return true;
});

return callback(metric_data);
}

if (delta_metrics->Size())
{
for (auto &col : collectors)
Expand Down
Loading