Skip to content

Conversation

santigimeno
Copy link
Contributor

In cmake/opentelemetry-proto.cmake and third_party_release which were not updated when upgrading to 1.5.0.

Refs: #3210 (comment)

In `cmake/opentelemetry-proto.cmake` and `third_party_release` which
were not updated when upgrading to `1.5.0`.
@santigimeno santigimeno requested a review from a team as a code owner January 24, 2025 11:32
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 6b3236d
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67937a6408ab160008586619

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (ced7986) to head (6b3236d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3254      +/-   ##
==========================================
+ Coverage   87.78%   87.80%   +0.02%     
==========================================
  Files         198      198              
  Lines        6324     6324              
==========================================
+ Hits         5551     5552       +1     
+ Misses        773      772       -1     

see 1 file with indirect coverage changes

@marcalff marcalff changed the title R[BUILD] Update opentelemetry-proto version [BUILD] Update opentelemetry-proto version Jan 24, 2025
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 72b0080 into open-telemetry:main Jan 24, 2025
56 of 57 checks passed
@psx95 psx95 mentioned this pull request Jan 24, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants