Skip to content

Conversation

owent
Copy link
Member

@owent owent commented Jan 29, 2025

Changes

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner January 29, 2025 17:44
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 6bc2c4c
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/679c4528eb98f7000805d5b3

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (52a80b5) to head (6bc2c4c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3260   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files         201      201           
  Lines        6385     6385           
=======================================
  Hits         5613     5613           
  Misses        772      772           

@owent owent force-pushed the shared_grpc_client branch from 98aea1d to 6bc2c4c Compare January 31, 2025 03:36
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the doc and example

@marcalff marcalff changed the title Add document and sample for sharing gRPC Client [DOC] Add document and sample for sharing gRPC Client Feb 1, 2025
@marcalff marcalff changed the title [DOC] Add document and sample for sharing gRPC Client [DOC] Add document and example for sharing gRPC Client Feb 1, 2025
@marcalff marcalff merged commit edb8937 into open-telemetry:main Feb 1, 2025
57 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Feb 2, 2025
[DOC] Add document and example for sharing gRPC Client (open-telemetry#3260)
@owent owent deleted the shared_grpc_client branch March 15, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants