Skip to content

Conversation

chusitoo
Copy link
Contributor

Fixes #3253

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 299ed11
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67a976df9852d80008b3cba4

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (5bc053e) to head (299ed11).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3263   +/-   ##
=======================================
  Coverage   87.96%   87.96%           
=======================================
  Files         205      205           
  Lines        6407     6407           
=======================================
  Hits         5635     5635           
  Misses        772      772           

@chusitoo chusitoo force-pushed the TestOtlpOnWindowsBuild branch from b9948e3 to db8c018 Compare February 10, 2025 02:45
@chusitoo chusitoo marked this pull request as ready for review February 10, 2025 04:51
@chusitoo chusitoo requested a review from a team as a code owner February 10, 2025 04:51
@lalitb
Copy link
Member

lalitb commented Feb 10, 2025

Thanks for the PR.

@github-actions
CI / CMake msvc (maintainer mode) (pull_request) Successful in 49m

Wondering if the delay is from the PR (gRPC build), or the CI env itself is slow.

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owent
Copy link
Member

owent commented Feb 10, 2025

Thanks for the PR.

@github-actions
CI / CMake msvc (maintainer mode) (pull_request) Successful in 49m

Wondering if the delay is from the PR (gRPC build), or the CI env itself is slow.

Installing grpc might take some time; alternatively, could it be included in the dev image?

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 3ca3c76 into open-telemetry:main Feb 10, 2025
57 checks passed
@marcalff marcalff changed the title [TEST] OTLP in Windows builds [CI] OTLP in Windows builds Feb 10, 2025
@marcalff
Copy link
Member

Thanks for the PR.

@github-actions
CI / CMake msvc (maintainer mode) (pull_request) Successful in 49m

Wondering if the delay is from the PR (gRPC build), or the CI env itself is slow.

Installing grpc might take some time; alternatively, could it be included in the dev image?

Looks like I missed this comment before hitting the merge button.

To address separately then, decide if/how to use default grpc, curl, etc packages on each platform, instead of building from source.

malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUILD] Build warning in http_operation_curl.cc on Windows

4 participants