Skip to content

[BUILD] Fix compilation with Regex being disabled #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2025
Merged

[BUILD] Fix compilation with Regex being disabled #3276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b072406
Fix compilation with Regex disabled:
kylepl Feb 15, 2025
95f834a
Only include algorithm if needed.
kylepl Feb 15, 2025
6857fc7
Fix where we reference the WORKING_REGEX.
kylepl Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/src/metrics/instrument_metadata_validator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,22 @@

#if OPENTELEMETRY_HAVE_WORKING_REGEX
# include <regex>
#else
# include <algorithm>
#endif

OPENTELEMETRY_BEGIN_NAMESPACE
namespace sdk
{
namespace metrics
{
#if OPENTELEMETRY_HAVE_WORKING_REGEX
// instrument-name = ALPHA 0*254 ("_" / "." / "-" / "/" / ALPHA / DIGIT)
const std::string kInstrumentNamePattern = "[a-zA-Z][-_./a-zA-Z0-9]{0,254}";
//
const std::string kInstrumentUnitPattern = "[\x01-\x7F]{0,63}";
// instrument-unit = It can have a maximum length of 63 ASCII chars
#endif

InstrumentMetaDataValidator::InstrumentMetaDataValidator()
#if OPENTELEMETRY_HAVE_WORKING_REGEX
Expand Down
Loading