Skip to content

[API] Change the param-pack unpacking order to start from left to right #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

[API] Change the param-pack unpacking order to start from left to right #3296

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bd3f39
Change the param-pack unpacking order to start from left to right
ThomsonTan Mar 11, 2025
dc03d42
Add fallback for c++14 and below
ThomsonTan Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions api/include/opentelemetry/logs/logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,16 @@ class Logger
return;
}

IgnoreTraitResult(detail::LogRecordSetterTrait<typename std::decay<ArgumentType>::type>::Set(
log_record.get(), std::forward<ArgumentType>(args))...);
//
// Keep the parameter pack unpacking order from left to right because left
// ones are usually more important like severity and event_id than the
// attributes. The left to right unpack order could pass the more important
// data to processors to avoid caching and memory allocating.
//
IgnoreTraitResult(
(detail::LogRecordSetterTrait<typename std::decay<ArgumentType>::type>::Set(
log_record.get(),
std::forward<ArgumentType>(args)),...));

EmitLogRecord(std::move(log_record));
}
Expand Down
Loading