Skip to content

Conversation

@PradSenn
Copy link

Fixes #

  1. Cardinality of the Aggregation limit (2000) is hardcoded and no ability to configure as part of the meter/aggregation
  2. Meter stores meter-name to storage in storage_registry_. When multiple views are added, the last view overrides the previous view, and collector can only emit the last view's metrics that are added.

  1. Introducing cardinality as configurable parameter in AggregationConfig, and implementing the limit from AggregationConfig in Storage
  2. Changing the storage_registry_ to keep track of view_name to storage, instead of metric_name to storage. So when multiple views are added, different view-names will be collected by collector.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@PradSenn PradSenn requested a review from a team as a code owner March 12, 2025 00:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 12, 2025

CLA Not Signed

@netlify
Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 0b0bd4c
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67d0d2e7d9668f000856243a

@lalitb lalitb self-assigned this Mar 12, 2025
@PradSenn PradSenn closed this Mar 12, 2025
@PradSenn PradSenn deleted the main branch March 12, 2025 00:32
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (dee5b0b) to head (0b0bd4c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
+ Coverage   89.49%   89.53%   +0.04%     
==========================================
  Files         208      208              
  Lines        6497     6500       +3     
==========================================
+ Hits         5814     5819       +5     
+ Misses        683      681       -2     
Files with missing lines Coverage Δ
...metry/sdk/metrics/aggregation/aggregation_config.h 100.00% <100.00%> (ø)
sdk/include/opentelemetry/sdk/metrics/meter.h 57.15% <ø> (ø)
...telemetry/sdk/metrics/state/async_metric_storage.h 94.60% <100.00%> (ø)
...entelemetry/sdk/metrics/state/attributes_hashmap.h 97.02% <100.00%> (+4.71%) ⬆️
...ntelemetry/sdk/metrics/state/sync_metric_storage.h 86.37% <100.00%> (ø)
sdk/src/metrics/meter.cc 82.50% <100.00%> (ø)
sdk/src/metrics/state/sync_metric_storage.cc 100.00% <100.00%> (ø)
sdk/src/metrics/state/temporal_metric_storage.cc 97.37% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants