Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Mar 21, 2025

Fixes #3310

Changes

The main thread of the grpc retry test now waits on a future until the grpc server is ready.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker requested a review from a team as a code owner March 21, 2025 21:00
@netlify
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d0c0908
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67e11fc9d636fc0008871edd

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (2566fb6) to head (d0c0908).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3311      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.02%     
==========================================
  Files         210      210              
  Lines        6522     6522              
==========================================
+ Hits         5837     5838       +1     
+ Misses        685      684       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Mar 24, 2025
@marcalff marcalff merged commit 4af490f into open-telemetry:main Mar 24, 2025
58 checks passed
@dbarker dbarker deleted the fix_otlp_grpc_retry_test branch March 31, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sporadic failure of OtlpGrpcExporterRetryIntegrationTests.StatusCodes test

3 participants