Skip to content

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Apr 1, 2025

Fixes #3334

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 37f7658
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67edbf75824dff0008a1bea2

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (c2a9397) to head (37f7658).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3335   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files         210      210           
  Lines        6502     6502           
=======================================
  Hits         5823     5823           
  Misses        679      679           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
Copy link
Member

dbarker commented Apr 1, 2025

@marcalff I've run into this same set of test failures shown here when trying to build with newer versions of protobuf required by newer versions of grpc. The issue has been reproducible using BUILD_SHARED_LIBS=ON for opentelemetry-cpp building against static libs for protobuf. However building static libs for otel-cpp work and tests pass. I've reproduced it going back to protobuf/5.27.0 + grpc/1.67.1 and on the latest version of protobuf/5.29.0 + grpc/1.71.0. I haven't logged a ticket yet and more investigation is needed.

@marcalff
Copy link
Member Author

marcalff commented Apr 1, 2025

@dbarker There are currently many failures piled one of top of another:

  • github bumped cmake to 4.0.0 in Ubuntu 22 and Ubuntu 24 images, starting with version 20250330.1.0
  • CMake 4.0.0 no longer supports cmake_minimum_required for CMake < 3.5
  • This in turns breaks the build for any dependency that uses a very old CMake, either directly, or in its own dependencies
  • This breaks the abseil build, the grpc build, and the opentracing build

Note that deployment of images 20250330.1.0 is still in progress, a build might use 20250330 and fail, while another might use 20250316 and pass

What I am looking for is:

  • which version of abseil to use, and it must work with C++14 for now (one issue at a time)
  • which version of grpc to use (same), was looking for 1.69.0
  • which version of protobuf to use, compatible with grpc

And the following must be adjusted accordingly:

  • CMakeLists for cmake
  • Bazel files for bazel
  • install scripts to download and install dependencies.

Any hint ?

@dbarker
Copy link
Member

dbarker commented Apr 1, 2025

Any hint ?

@marcalff I have some working combinations of abseil, protobuf, and grpc in this file. However the best I could do was to get the static builds passing tests with later versions of protobuf. This required installing abseil, protobuf, and grpc separately and ensure protobuf and grpc don't use submodules for those. The shared libs builds fail the otlp file and otlp http tests with the newer protobuf so I excluded them to avoid tackling that problem in my PR.

I'm thinking that downgrading cmake may be a quicker solution for this PR and release. I can help write some scripts if needed.

@marcalff
Copy link
Member Author

marcalff commented Apr 7, 2025

Closing, outdated PR.

@marcalff marcalff closed this Apr 7, 2025
@marcalff marcalff deleted the fix_cmake_min_version branch October 18, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI broken by CMake upgrade in ubuntu images

2 participants