Skip to content

Conversation

@dbarker
Copy link
Member

@dbarker dbarker commented Apr 1, 2025

Pin cmake to version 3.31.6 in ci

Changes

  • changes the setup_cmake.sh script to remove the system installed cmake and install a specific version from env var CMAKE_VERSION that defaults to 3.31.6
  • adds a setup_cmake.ps1 script for windows that does the same
  • call the scripts in the ci workflow where needed

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit ef95750
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67ec2e8574860200081799e0

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (b2bc73f) to head (ef95750).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3336      +/-   ##
==========================================
- Coverage   89.52%   89.51%   -0.01%     
==========================================
  Files         210      210              
  Lines        6526     6526              
==========================================
- Hits         5842     5841       -1     
- Misses        684      685       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review April 1, 2025 19:23
@dbarker dbarker requested a review from a team as a code owner April 1, 2025 19:23
@dbarker
Copy link
Member Author

dbarker commented Apr 1, 2025

@marcalff this pr is an option to give more time for the cmake upgrade if needed.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as Intrmediate fix, to unblock release.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok as an intermediate fix:

  • it touches only files used in CI, production code unchanged
  • it restores CI to a working state after the CMake 4.0.0 forced upgrade

We will need later to support CMake 4.0.0

@marcalff
Copy link
Member

marcalff commented Apr 1, 2025

@dbarker Thanks. Let's use this then.

@marcalff marcalff merged commit 83ac2ae into open-telemetry:main Apr 1, 2025
56 checks passed
@marcalff marcalff changed the title pin cmake in ci and devcontainer [CI] pin cmake in ci and devcontainer Apr 1, 2025
@dbarker dbarker deleted the fix_pin_cmake_in_ci branch April 1, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants