Skip to content

Conversation

@ethandmd
Copy link
Contributor

@ethandmd ethandmd commented Apr 4, 2025

Fixes #1391

Changes

Adds Base2 Exponential Histogram Aggregation to the sdk with additional test cases.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 4, 2025

CLA Missing ID CLA Not Signed

@netlify
Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 98c97cd
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67f00229cc0bf000086713fc

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label Apr 4, 2025
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 62.87425% with 62 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (6175aa0) to head (98c97cd).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...egation/base2_exponential_histogram_aggregation.cc 71.64% 40 Missing ⚠️
exporters/ostream/src/metric_exporter.cc 0.00% 18 Missing ⚠️
...etry/sdk/metrics/aggregation/default_aggregation.h 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3343      +/-   ##
==========================================
- Coverage   89.56%   88.90%   -0.66%     
==========================================
  Files         210      211       +1     
  Lines        6502     6673     +171     
==========================================
+ Hits         5823     5932     +109     
- Misses        679      741      +62     
Files with missing lines Coverage Δ
...metry/sdk/metrics/aggregation/aggregation_config.h 100.00% <ø> (ø)
...nclude/opentelemetry/sdk/metrics/data/point_data.h 100.00% <100.00%> (ø)
...etry/sdk/metrics/aggregation/default_aggregation.h 76.55% <0.00%> (-3.97%) ⬇️
exporters/ostream/src/metric_exporter.cc 79.14% <0.00%> (-11.77%) ⬇️
...egation/base2_exponential_histogram_aggregation.cc 71.64% <71.64%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ethandmd ethandmd closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:waiting-on-cla Waiting on CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics SDK] Add support for Exponential Histogram Aggregation

4 participants