Skip to content

[SDK] Set small initial value for AttributesHashMap::hash_map_ #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SDK] Set small initial value for AttributesHashMap::hash_map_ #3391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33d590a
[SDK] Set small initial value for AttributesHashMap::hash_map_
ThomsonTan May 7, 2025
19648aa
Update changelog
ThomsonTan May 7, 2025
f19b6e2
Fix syntax
ThomsonTan May 7, 2025
6821f60
Merge branch 'main' into set_bucket_count_for_hash_map
marcalff May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ Increment the:

## [Unreleased]

* [SDK] Set small initial value for AttributesHashMap::hash_map_
[#3391](https://github.com/open-telemetry/opentelemetry-cpp/pull/3391)

* [Metrics SDK] Use nostd::function_ref in AttributesHashMap
[#3393](https://github.com/open-telemetry/opentelemetry-cpp/pull/3393)

Expand Down
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/metrics/state/attributes_hashmap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class AttributesHashMapWithCustomHash
{
public:
AttributesHashMapWithCustomHash(size_t attributes_limit = kAggregationCardinalityLimit)
: attributes_limit_(attributes_limit)
: hash_map_(1), attributes_limit_(attributes_limit)
{}
Aggregation *Get(const MetricAttributes &attributes) const
{
Expand Down
Loading