Skip to content

Conversation

@dbarker
Copy link
Member

@dbarker dbarker commented May 20, 2025

Test for #3405 - This draft PR is just to demonstrate the current state of building opentelemetry-cpp shared libraries against newer versions of protobuf and grpc.

Changes

  • adds cmake install tests for
    • Building shared otel-cpp libs against static protobuf v5.27 and grpc v1.67 libs - This is known to fail tests and the otlp cmake targets do not function as expected (either segfault or just fail to export data)
    • Building shared otel-cpp libs against shared protobuf v5.27 and grpc v1.67 libs - The otlp grpc tests fail to build, but the otlp grpc cmake targets can be used in an application and work as expected.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker added the pr:do-not-merge This PR is not ready to be merged. label May 20, 2025
@netlify
Copy link

netlify bot commented May 20, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit cbfc058
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/682cd24083e30d000887f3ef

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (29ac517) to head (cbfc058).
Report is 36 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3427   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files         212      212           
  Lines        6937     6937           
=======================================
  Hits         6246     6246           
  Misses        691      691           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
Copy link
Member Author

dbarker commented Jun 24, 2025

Closing this as addressed by #3435

@dbarker dbarker closed this Jun 24, 2025
@dbarker dbarker deleted the test_linking_shared_protobuf_grpc branch July 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:do-not-merge This PR is not ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant