Skip to content

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented May 30, 2025

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Expand the iwyu CI to cover examples
  • Fixed the issues reported

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented May 30, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 10b26fa
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/683a0389341c1b000875c7a4

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (7a847ca) to head (10b26fa).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
+ Coverage   89.86%   89.88%   +0.02%     
==========================================
  Files         212      212              
  Lines        6941     6941              
==========================================
+ Hits         6237     6238       +1     
+ Misses        704      703       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff marked this pull request as ready for review May 30, 2025 19:00
@marcalff marcalff requested a review from a team as a code owner May 30, 2025 19:00
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iwyu tool never makes it to the otlp grpc examples due to a segfault (#3453). This isn't new so shouldn't block this PR.

@marcalff marcalff merged commit 76460cf into open-telemetry:main May 31, 2025
67 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request May 31, 2025
@marcalff marcalff deleted the fix_iwyu_examples branch October 18, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants