Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jun 9, 2025

Contributes to #2481

This is a partial fix, that implements supporting declarations.

Changes

Please provide a brief description of the changes here.

  • Implement the trace model for file configuration.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e75a6ac
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/685eb0b917924e000814c512

@marcalff marcalff marked this pull request as ready for review June 9, 2025 09:13
@marcalff marcalff requested a review from a team as a code owner June 9, 2025 09:13
@marcalff marcalff added the pr:please-review This PR is ready for review label Jun 9, 2025
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (b49e1b7) to head (e75a6ac).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3467      +/-   ##
==========================================
+ Coverage   89.95%   89.99%   +0.05%     
==========================================
  Files         219      219              
  Lines        7051     7051              
==========================================
+ Hits         6342     6345       +3     
+ Misses        709      706       -3     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff
Copy link
Member Author

@lalitb @ThomsonTan @esigo Please review

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcalff marcalff merged commit 89b6d0f into main Jun 27, 2025
70 checks passed
@marcalff marcalff deleted the merge_config_trace_model branch June 27, 2025 17:50
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jun 27, 2025
[CONFIGURATION] File configuration - trace model (open-telemetry#3467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants