-
Notifications
You must be signed in to change notification settings - Fork 501
[CONFIGURATION] File configuration - trace model #3467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3467 +/- ##
==========================================
+ Coverage 89.95% 89.99% +0.05%
==========================================
Files 219 219
Lines 7051 7051
==========================================
+ Hits 6342 6345 +3
+ Misses 709 706 -3 🚀 New features to boost your workflow:
|
sdk/include/opentelemetry/sdk/configuration/otlp_file_span_exporter_configuration.h
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/configuration/otlp_http_span_exporter_configuration.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdk/include/opentelemetry/sdk/configuration/batch_span_processor_configuration.h
Show resolved
Hide resolved
@lalitb @ThomsonTan @esigo Please review |
sdk/include/opentelemetry/sdk/configuration/span_limits_configuration.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
[CONFIGURATION] File configuration - trace model (open-telemetry#3467)
Contributes to #2481
This is a partial fix, that implements supporting declarations.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes