Skip to content

[CI] Increase code coverage of iwyu and clang-tidy ci jobs #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 16, 2025
Merged

[CI] Increase code coverage of iwyu and clang-tidy ci jobs #3469

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7044771
add more code coverage to iwyu and clang-tidy ci jobs
dbarker Jun 9, 2025
90e8fb2
Merge branch 'main' into ci_enable_more_cmake_options_with_qa_tools
dbarker Jun 9, 2025
100b30c
add warning limit and failure condition for the clang-tidy job. Updat…
dbarker Jun 9, 2025
24a5123
annotate the clang-tidy count warning for the github workflow job
dbarker Jun 9, 2025
13149e4
add testing matrix to iwyu and clang-tidy jobs. Move cmake options to…
dbarker Jun 11, 2025
e807e3b
set fail-fast false on the strategy to get current warning counts. Cl…
dbarker Jun 11, 2025
aad7ac8
update iwyu warning limits. use cmake args to trigger clang-tidy. dis…
dbarker Jun 11, 2025
a2851c2
disable deprecation warnings with clang-tidy jobs. Disable clang-tidy…
dbarker Jun 11, 2025
4ee650a
Merge remote-tracking branch 'origin/main' into ci_enable_more_cmake_…
dbarker Jun 11, 2025
7ea594c
set the clang-tidy warning limits. fix iwyu error count step
dbarker Jun 11, 2025
5f344ee
Merge branch 'main' into ci_enable_more_cmake_options_with_qa_tools
marcalff Jun 12, 2025
87c2208
Merge branch 'main' into ci_enable_more_cmake_options_with_qa_tools
marcalff Jun 13, 2025
08a5c57
address feedback
dbarker Jun 15, 2025
145e455
increase warning limit for abvi1 iwyu case to 5
dbarker Jun 15, 2025
e7de1bd
Merge branch 'main' into ci_enable_more_cmake_options_with_qa_tools
marcalff Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .github/workflows/clang-tidy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,15 @@ jobs:
sudo apt install -y --no-install-recommends --no-install-suggests \
build-essential \
cmake \
zlib1g-dev \
libssl-dev \
libcurl4-openssl-dev \
nlohmann-json3-dev \
libabsl-dev \
libprotobuf-dev \
libgrpc++-dev \
protobuf-compiler \
protobuf-compiler-grpc \
libgmock-dev \
libgtest-dev \
libbenchmark-dev
Expand All @@ -57,6 +62,14 @@ jobs:
cmake -B build \
-DCMAKE_CXX_STANDARD=14 \
-DWITH_STL=CXX14 \
-DWITH_ABI_VERSION_1=OFF \
-DWITH_ABI_VERSION_2=ON \
-DWITH_HTTP_CLIENT_CURL=ON \
-DWITH_THREAD_INSTRUMENTATION_PREVIEW=ON \
-DWITH_OTLP_GRPC_SSL_MTLS_PREVIEW=ON \
-DWITH_OTLP_GRPC_CREDENTIAL_PREVIEW=ON \
-DWITH_OTLP_RETRY_PREVIEW=ON \
-DWITH_OTLP_GRPC=ON \
-DWITH_OTLP_HTTP=ON \
-DWITH_OTLP_FILE=ON \
-DWITH_PROMETHEUS=ON \
Expand All @@ -82,7 +95,16 @@ jobs:

- name: Count warnings
run: |
clang-tidy --version
COUNT=$(grep -c "warning:" clang-tidy.log)
echo "clang-tidy reported ${COUNT} warning(s)"
readonly WARNING_LIMIT=216
# FAIL the build if COUNT > WARNING_LIMIT
if [ $COUNT -gt $WARNING_LIMIT ] ; then
echo "clang-tidy reported ${COUNT} warning(s) exceeding the existing warning limit of ${WARNING_LIMIT}"
exit 1
# WARN in annotations if COUNT > 0
elif [ $COUNT -gt 0 ] ; then
echo "::warning::clang-tidy reported ${COUNT} warning(s)"
fi

# TODO: include WITH_OTLP_GRPC flags.
13 changes: 11 additions & 2 deletions .github/workflows/iwyu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,18 @@ jobs:
-DWITH_OTLP_FILE=ON \
-DWITH_OPENTRACING=ON \
-DWITH_OTLP_HTTP_COMPRESSION=ON \
-DWITH_THREAD_INSTRUMENTATION=ON \
-DWITH_ZIPKIN=ON \
-DWITH_PROMETHEUS=ON \
-DWITH_ELASTICSEARCH=ON \
-DWITH_HTTP_CLIENT_CURL=ON \
-DWITH_ABI_VERSION_1=OFF \
-DWITH_ABI_VERSION_2=ON \
-DWITH_METRICS_EXEMPLAR_PREVIEW=ON \
-DWITH_ASYNC_EXPORT_PREVIEW=ON \
-DWITH_THREAD_INSTRUMENTATION_PREVIEW=ON \
-DWITH_OTLP_GRPC_SSL_MTLS_PREVIEW=ON \
-DWITH_OTLP_GRPC_CREDENTIAL_PREVIEW=ON \
-DWITH_OTLP_RETRY_PREVIEW=ON \
..

- name: iwyu_tool
Expand All @@ -87,7 +96,7 @@ jobs:
readonly WARNING_COUNT=`grep -c "include-what-you-use reported diagnostics:" iwyu.log`
echo "include-what-you-use reported ${WARNING_COUNT} warning(s)"
# Acceptable limit, to decrease over time down to 0
readonly WARNING_LIMIT=0
readonly WARNING_LIMIT=48
# FAIL the build if WARNING_COUNT > WARNING_LIMIT
if [ $WARNING_COUNT -gt $WARNING_LIMIT ] ; then
exit 1
Expand Down
Loading