Skip to content

Add bundle version of utf8_range to validate attributes #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owent wants to merge 38 commits into
base: main
Choose a base branch
from
+1,422 −36

Merge branch 'main' into validate_utf8_string_in_setters

893fc56
Select commit
Loading
Failed to load commit list.
Open

Add bundle version of utf8_range to validate attributes #3512

Merge branch 'main' into validate_utf8_string_in_setters
893fc56
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 29, 2025 in 0s

88.97% (-0.96%) compared to 9de3493

View this Pull Request on Codecov

88.97% (-0.96%) compared to 9de3493

Details

Codecov Report

❌ Patch coverage is 58.62069% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.97%. Comparing base (9de3493) to head (893fc56).

Files with missing lines Patch % Lines
sdk/src/common/attribute_validity.cc 56.10% 36 Missing ⚠️
sdk/src/common/internal/utf8_range/uft8_range.cc 50.00% 33 Missing ⚠️
...lude/opentelemetry/sdk/common/attribute_validity.h 63.64% 12 Missing ⚠️
...y/sdk/instrumentationscope/instrumentation_scope.h 61.12% 7 Missing ⚠️
sdk/src/trace/span.cc 64.71% 6 Missing ⚠️
...ntelemetry/sdk/metrics/view/attributes_processor.h 66.67% 1 Missing ⚠️
sdk/src/resource/resource.cc 92.31% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3512      +/-   ##
==========================================
- Coverage   89.93%   88.97%   -0.96%     
==========================================
  Files         225      228       +3     
  Lines        7158     7376     +218     
==========================================
+ Hits         6437     6562     +125     
- Misses        721      814      +93
Files with missing lines Coverage Δ
...ntelemetry/sdk/metrics/view/attributes_processor.h 84.62% <66.67%> (ø)
sdk/src/resource/resource.cc 95.13% <92.31%> (-1.65%) ⬇️
sdk/src/trace/span.cc 85.72% <64.71%> (-4.05%) ⬇️
...y/sdk/instrumentationscope/instrumentation_scope.h 87.28% <61.12%> (-12.72%) ⬇️
...lude/opentelemetry/sdk/common/attribute_validity.h 63.64% <63.64%> (ø)
sdk/src/common/internal/utf8_range/uft8_range.cc 50.00% <50.00%> (ø)
sdk/src/common/attribute_validity.cc 56.10% <56.10%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov