Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Jul 7, 2025

Fixes # (issue)

Changes

  • Add CMake script to find or fetch Microsoft.GSL
  • Add Microsoft.GSL to the list of supported third party packages
  • Test WITH_GSL through the Windows cmake.install.test

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

…SL to the list of supported third party packages. Test WITH_GSL through the windows cmake.install.test
@netlify
Copy link

netlify bot commented Jul 7, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 79aab53
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/686eda8ac6db290008b992d0

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (6c4d45c) to head (79aab53).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3521   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         219      219           
  Lines        7051     7051           
=======================================
  Hits         6343     6343           
  Misses        708      708           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review July 7, 2025 18:16
@dbarker dbarker requested a review from a team as a code owner July 7, 2025 18:16
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marcalff marcalff merged commit d017ae1 into open-telemetry:main Jul 10, 2025
70 checks passed
@dbarker dbarker deleted the cmake_find_or_fetch_ms_gsl branch July 10, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants