Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Jul 16, 2025

Follow up to #3435

Changes

  • add test step to the CMake install ci workflow that builds shared otel-cpp libs linked to the latest static protobuf and grpc libs.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Jul 16, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 469a0cb
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6878a1d194793800081bdca1

@dbarker dbarker changed the title [TEST] test building shared otel-cpp libs linked to static protobuf and grpc… [TEST] test building shared otel-cpp libs linked to latest static protobuf and grpc Jul 16, 2025
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (b7b0278) to head (469a0cb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3544      +/-   ##
==========================================
+ Coverage   89.97%   89.99%   +0.02%     
==========================================
  Files         219      219              
  Lines        7048     7048              
==========================================
+ Hits         6341     6342       +1     
+ Misses        707      706       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker changed the title [TEST] test building shared otel-cpp libs linked to latest static protobuf and grpc [TEST] Shared otel-cpp libs linked to latest static protobuf and grpc Jul 16, 2025
@dbarker dbarker marked this pull request as ready for review July 16, 2025 16:04
@dbarker dbarker requested a review from a team as a code owner July 16, 2025 16:04
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit 0e51e67 into open-telemetry:main Jul 17, 2025
70 checks passed
@dbarker dbarker deleted the test_shared_otel_linked_to_latest_grpc branch July 17, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants