-
Notifications
You must be signed in to change notification settings - Fork 501
[CONFIGURATION] File configuration - sdk builder #3550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3550 +/- ##
==========================================
+ Coverage 90.01% 90.03% +0.02%
==========================================
Files 220 220
Lines 7065 7065
==========================================
+ Hits 6359 6360 +1
+ Misses 706 705 -1 🚀 New features to boost your workflow:
|
Thanks for the PR @marcalff. Just noted a few nitpicks (optional) and a request to add a test for the ConfiguredSdk class if that is reasonable. |
@dbarker Thanks for this round of comments. All addressed, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Contributes to #2481
This is a partial fix, that implements the sdk builder.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes