Skip to content

Conversation

marcalff
Copy link
Member

Contributes to #2481

This is a partial fix, that implements the sdk builder.

Changes

Please provide a brief description of the changes here.

  • Implement the sdk builder:
    • Create opentelemetry-cpp SDK objects from the configuration model.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner July 17, 2025 22:50
Copy link

netlify bot commented Jul 17, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 698d752
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68800f0bd5860a0008d1c4e3

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (c3a0ac1) to head (698d752).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3550      +/-   ##
==========================================
+ Coverage   90.01%   90.03%   +0.02%     
==========================================
  Files         220      220              
  Lines        7065     7065              
==========================================
+ Hits         6359     6360       +1     
+ Misses        706      705       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
Copy link
Member

dbarker commented Jul 19, 2025

Thanks for the PR @marcalff. Just noted a few nitpicks (optional) and a request to add a test for the ConfiguredSdk class if that is reasonable.

@marcalff
Copy link
Member Author

@dbarker Thanks for this round of comments.

All addressed, PTAL.

Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@marcalff marcalff merged commit aeb5a01 into main Jul 23, 2025
115 of 116 checks passed
@marcalff marcalff deleted the merge_config_sdk_builder branch July 23, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants