[SDK] Update default exemplar reservoir size for exponential histograms #3551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3551 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 220 220
Lines 7056 7056
=======================================
Hits 6350 6350
Misses 706 706 🚀 New features to boost your workflow:
|
marcalff
reviewed
Jul 18, 2025
Merged
3 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set SimpleFixedSizeExemplarReservoir default size for exponential histograms based on configured maximum bucket count as recommended in the spec:
https://github.com/open-telemetry/opentelemetry-specification/blob/v1.46.0/specification/metrics/sdk.md#exemplar-defaults
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changesNote that I didn't update any tests (yet) - I couldn't find any existing tests for the fixed size reservoir? Thus wasn't sure if explicit tests are needed or if this is considered small / covered by other tests?