Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jul 23, 2025

Contributes to #2481

This is a partial fix, to align on the declarative configuration specs version 1.0.0-rc1

Changes

Please provide a brief description of the changes here.

Adjusted the implementation to recent spec changes:

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner July 23, 2025 21:24
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e29f15b
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6882668f5c6e82000896ec82

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (fdee87f) to head (e29f15b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3557      +/-   ##
==========================================
+ Coverage   90.01%   90.03%   +0.02%     
==========================================
  Files         220      220              
  Lines        7065     7065              
==========================================
+ Hits         6359     6360       +1     
+ Misses        706      705       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! minor nitpick on variable initialization

@marcalff marcalff merged commit dbd0680 into main Jul 24, 2025
70 checks passed
@marcalff marcalff deleted the merge_config_align_spec_1.0.0-rc1 branch July 24, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants