Skip to content

Conversation

markus456
Copy link
Contributor

@markus456 markus456 commented Jul 27, 2025

The libraries that opentelemetry-cpp requires have minimum required versions which are higher than the ones that are natively available on the systems being tested. By listing the exact versions of the libraries, the dependencies are clearly stated which removes the guesswork from build problems.

This contribution is submitted by me as an individual.

Fixes #3560

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

The libraries that opentelemetry-cpp requires have minimum required versions which are higher than the ones that are natively available on the systems being tested. By listing the exact versions of the libraries, the dependencies are clearly stated which removes the guesswork from build problems.
Copy link

netlify bot commented Jul 27, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit f61493d
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68889d0cbb8b630008e1e396

@markus456 markus456 marked this pull request as ready for review July 27, 2025 07:07
@markus456 markus456 requested a review from a team as a code owner July 27, 2025 07:07
Typo of authoritative.
Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (ba38077) to head (f61493d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3562   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         220      220           
  Lines        7069     7069           
=======================================
  Hits         6364     6364           
  Misses        705      705           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
Copy link
Member

dbarker commented Jul 27, 2025

Thanks for the PR @markus456! The changes generally look good. Just a few CI failures on the third_party_minimum file link in the DocFX check and some markdown-lint errors. Please address them and I'll approve.

The link used a relative path when the rest of them used absolue ones and the lines were above the 80 line limit.
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@marcalff marcalff changed the title Document minimum required versions [DOC] Document minimum required versions Jul 28, 2025
@lalitb
Copy link
Member

lalitb commented Jul 28, 2025

It would’ve been sufficient to just reference third_party_minimum. Maintaining version numbers in multiple places can lead to inconsistencies and is harder to keep in sync.

@markus456
Copy link
Contributor Author

That was what I initially was planning on doing but given that there are not that many external dependencies and that they appear to not change super frequently, I figured it'd be nicer for the end-user to just directly see it from the markdown document. If it's too much, it can of course be removed.

@marcalff
Copy link
Member

It would’ve been sufficient to just reference third_party_minimum. Maintaining version numbers in multiple places can lead to inconsistencies and is harder to keep in sync.

This also helps ease of use, even if this means a (little) more maintenance on changes.

Having to follow a trail of bread crumbs just to figure out what is needed to start with opentelemetry-cpp increases the barrier of entry, and the cost of taking the wrong path (build failures as reported) right from the start can be a show stopper preventing adoption.

It is a tradeoff with maintenance, but has merits too.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the doc.

@marcalff marcalff merged commit 495f497 into open-telemetry:main Jul 29, 2025
115 of 116 checks passed
@lalitb
Copy link
Member

lalitb commented Jul 29, 2025

Having to follow a trail of bread crumbs just to figure out what is needed to start with opentelemetry-cpp increases the barrier of entry, and the cost of taking the wrong path (build failures as reported) right from the start can be a show stopper preventing adoption.

What if we keep the single source but make the path more obvious? Like adding a clear callout in INSTALL.md, something like "Quick Start Prerequisites". Or maybe auto-generate this information from canonical source.

Anyway, nothing against this PR - it's already merged and addresses a real user pain point. Just something to think about for future cases like this. For now, hopefully we can keep both places updated when versions change.

nikhilbhatia08 pushed a commit to nikhilbhatia08/opentelemetry-cpp that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake configuration on Ubuntu 20.04 fails with v1.22.0

4 participants