Skip to content

Conversation

dws
Copy link
Contributor

@dws dws commented Aug 21, 2025

It does not appear that the Bazel build of this repo makes any use of rules_foreign_cc, so we here remove its default definition.

Fixes #3600

Changes

We here drop a default definition of rules_foreign_cc from the WORKSPACE-based setup for building this repo under Bazel.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

It does not appear that this repo makes any use of rules_foreign_cc,
so we here remove it.
Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 902bd57
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68a86bd2e2dc8c00084ed25b

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (7c34c0f) to head (902bd57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3601   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         220      220           
  Lines        7069     7069           
=======================================
  Hits         6364     6364           
  Misses        705      705           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dws dws marked this pull request as ready for review August 22, 2025 00:20
@dws dws requested a review from a team as a code owner August 22, 2025 00:20
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title drop rules_foreign_cc as a dependency [BAZEL] Drop rules_foreign_cc as a dependency Aug 22, 2025
@marcalff marcalff merged commit fae81fa into open-telemetry:main Aug 22, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opentelemetry-cpp no longer needs rules_foreign_cc

3 participants