Skip to content

Conversation

marcalff
Copy link
Member

Contributes to #2481

This is a partial fix, to implement functional tests for file configuration.

Changes

Please provide a brief description of the changes here.

  • Implement functional tests for file configuration.
  • Fix missing include in string_util.h, for isspace.
  • Code cleanup in sdk_builder.cc, now that issue [SDK] View should not have a unit #3547 is resolved.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner August 22, 2025 22:38
Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 110fc13
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68aa05a3f34d4d00089a176c

Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (6d7b8ad) to head (fc5f0c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3606      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.01%     
==========================================
  Files         220      220              
  Lines        7069     7069              
==========================================
- Hits         6364     6363       -1     
- Misses        705      706       +1     
Files with missing lines Coverage Δ
api/include/opentelemetry/common/string_util.h 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added the pr:please-review This PR is ready for review label Aug 22, 2025
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@marcalff marcalff merged commit e79967b into main Aug 28, 2025
66 of 67 checks passed
@marcalff marcalff deleted the merge_config_functional_tests branch August 28, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants