Skip to content

Conversation

stephan-cr
Copy link
Contributor

Fixes #3659

Changes

Fix MinGW GCC cross compilation build on Linux for Windows. Linux expects lowercase header file names (Windows is case insensitive).

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@stephan-cr stephan-cr requested a review from a team as a code owner September 26, 2025 20:40
Copy link

linux-foundation-easycla bot commented Sep 26, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: stephan-cr / name: Stephan Creutz (5344c9a)

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (5540dae) to head (5344c9a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3666      +/-   ##
==========================================
+ Coverage   90.08%   90.11%   +0.03%     
==========================================
  Files         221      221              
  Lines        7135     7135              
==========================================
+ Hits         6427     6429       +2     
+ Misses        708      706       -2     
Files with missing lines Coverage Δ
sdk/src/common/fast_random_number_generator.h 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Fix MinGW GCC cross compilation build on Linux for Windows [BUILD] Fix MinGW GCC cross compilation build on Linux for Windows Sep 27, 2025
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@marcalff marcalff merged commit 0875ca1 into open-telemetry:main Sep 28, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cross-compilation with MinGW GCC for Windows on Linux fails

3 participants