-
Notifications
You must be signed in to change notification settings - Fork 499
[CONFIGURATION] File configuration - cmake install #3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3668 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.01%
==========================================
Files 222 222
Lines 7154 7154
==========================================
- Hits 6448 6447 -1
- Misses 706 707 +1 🚀 New features to boost your workflow:
|
This PR is great :). I think it is reasonable to disable the opentelemetry-cpp/ci/do_ci.ps1 Line 423 in 7b3dbd0
|
Yes, thanks for the pointer. The install dll test is in such a state that it needs a lot of work, not only for WITH_CONFIGURATION. Disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Contributes to #2481
This is a partial fix, to implement the cmake install tests.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes