Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Sep 28, 2025

Contributes to #2481

This is a partial fix, to implement the cmake install tests.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (66f5e70) to head (e1254f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3668      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.01%     
==========================================
  Files         222      222              
  Lines        7154     7154              
==========================================
- Hits         6448     6447       -1     
- Misses        706      707       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
Copy link
Member

dbarker commented Oct 1, 2025

This PR is great :). I think it is reasonable to disable the WITH_CONFIGURATION for the cmake.dll.install.test to move forward. Adding configuration to the dll can be a follow up PR later.

cmake $SRC_DIR `

@marcalff
Copy link
Member Author

marcalff commented Oct 1, 2025

This PR is great :). I think it is reasonable to disable the WITH_CONFIGURATION for the cmake.dll.install.test to move forward. Adding configuration to the dll can be a follow up PR later.

cmake $SRC_DIR `

Yes, thanks for the pointer.

The install dll test is in such a state that it needs a lot of work, not only for WITH_CONFIGURATION.

Disabled.

@marcalff marcalff marked this pull request as ready for review October 1, 2025 19:52
@marcalff marcalff requested a review from a team as a code owner October 1, 2025 19:52
@marcalff marcalff added the pr:please-review This PR is ready for review label Oct 1, 2025
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@marcalff marcalff merged commit 9b38749 into main Oct 2, 2025
67 checks passed
@marcalff marcalff deleted the merge_config_cmake_install branch October 2, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants