Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Sep 30, 2025

Fixes an issue where setting WITH_METRICS_EXEMPLAR_PREVIEW=OFF causes the metrics unit tests to fail.

Changes

  • Add the missing guard on adding the exemplar test directory

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@dbarker dbarker marked this pull request as ready for review September 30, 2025 03:14
@dbarker dbarker requested a review from a team as a code owner September 30, 2025 03:14
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (064dfe3) to head (0cb895a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3675   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files         221      221           
  Lines        7135     7135           
=======================================
  Hits         6429     6429           
  Misses        706      706           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff merged commit 7b3dbd0 into open-telemetry:main Sep 30, 2025
67 checks passed
@dbarker dbarker deleted the fix_missing_exemplar_preview_guard branch October 4, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants