Skip to content

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Oct 1, 2025

Changes

This pull request makes a consistent naming correction across the codebase, changing the method name GetAllEnteries to the correct spelling GetAllEntries. This update affects the implementation, usage in metric storage logic, and related unit tests.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team as a code owner October 1, 2025 18:38
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (90db398) to head (baa8d51).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3680   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files         221      221           
  Lines        7135     7135           
=======================================
  Hits         6429     6429           
  Misses        706      706           
Files with missing lines Coverage Δ
...entelemetry/sdk/metrics/state/attributes_hashmap.h 98.42% <100.00%> (ø)
sdk/src/metrics/state/temporal_metric_storage.cc 97.34% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff merged commit 881daad into open-telemetry:main Oct 1, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants