Skip to content

Conversation

keith
Copy link
Contributor

@keith keith commented Oct 16, 2025

With the next major version of bazel this becomes required. This change
was automated with buildifier -r . --lint=fix

With the next major version of bazel this becomes required. This change
was automated with `buildifier -r . --lint=fix`
@keith keith requested a review from a team as a code owner October 16, 2025 00:56
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (767ef30) to head (813dc8f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3697   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         225      225           
  Lines        7273     7273           
=======================================
  Hits         6542     6542           
  Misses        731      731           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Not a bagel expert, but trusting the buildifier gods on this one :)
Seems the CI failure is not related to the PR, something related to vcpkg. cc @ThomsonTan

@lalitb
Copy link
Member

lalitb commented Oct 16, 2025

Approved earlier, but noticed another CI failure (Cannot load '@@rules_cc//cc:cc_library.bzl': no such file).
Likely missing rules_cc declaration in WORKSPACE or MODULE.bazel — seems Bazel 7 now requires it explicitly.

make command: make -k -j $(nproc)
CMAKE_OPTIONS: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_STANDARD_REQUIRED=ON -DCMAKE_CXX_EXTENSIONS=OFF
2025/10/16 00:59:13 Downloading https://releases.bazel.build/7.1.1/release/bazel-7.1.1-linux-x86_64...
Starting local Bazel server and connecting to it...
Computing main repo mapping: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//exporters/otlp:with_otlp_grpc_credential_preview': error loading package 'exporters/otlp': cannot load '@@rules_cc//cc:cc_library.bzl': no such file
ERROR: //exporters/otlp:with_otlp_grpc_credential_preview :: Error loading option //exporters/otlp:with_otlp_grpc_credential_preview: error loading package 'exporters/otlp': cannot load '@@rules_cc//cc:cc_library.bzl': no such file
Error: Process completed with exit code 2.

@keith
Copy link
Contributor Author

keith commented Oct 16, 2025

thanks, wdyt about dropping WORKSPACE support now? #3699

I can fix it here but it might be a reasonable time to drop anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants