Skip to content

[CONFIGURATION] File configuration - implement cardinality_limits#3820

Merged
marcalff merged 7 commits intoopen-telemetry:mainfrom
marcalff:config_cardinality_limits
Jan 21, 2026
Merged

[CONFIGURATION] File configuration - implement cardinality_limits#3820
marcalff merged 7 commits intoopen-telemetry:mainfrom
marcalff:config_cardinality_limits

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Jan 19, 2026

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff marked this pull request as ready for review January 19, 2026 21:55
@marcalff marcalff requested a review from a team as a code owner January 19, 2026 21:55
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.96%. Comparing base (ff5f07a) to head (0a7dd79).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3820   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         225      225           
  Lines        7170     7170           
=======================================
  Hits         6450     6450           
  Misses        720      720           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

const std::unique_ptr<DocumentNode> &node) const
{
auto model = std::make_unique<CardinalityLimitsConfiguration>();
std::unique_ptr<DocumentNode> child;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unused child variable.

Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants