[BUILD] Update vendored TraceLoggingDynamic.h to compile with msvc's conformant preprocessor#3822
Merged
marcalff merged 3 commits intoopen-telemetry:mainfrom Jan 21, 2026
Merged
Conversation
(preserving existing SPDX header)
|
|
Contributor
Author
|
/easycla |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3822 +/- ##
==========================================
+ Coverage 89.95% 89.96% +0.02%
==========================================
Files 225 225
Lines 7170 7170
==========================================
+ Hits 6449 6450 +1
+ Misses 721 720 -1 🚀 New features to boost your workflow:
|
Member
|
CI should be clean after #3823 is merged. |
ThomsonTan
approved these changes
Jan 21, 2026
Member
|
/easycla |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3809
Changes
Update vendored copy of TraceLoggingDynamic.h to 62163825ca08a33188a8e006cd0d56d498a90e73. Or in other words, picks up my PR Fix: TraceLoggingDynamic.h failing under /Zc:preprocessor on msvc into the upstream tracelogging repo.
The motivating reason to pick up this version is this backwards-compatible fix:
Which relied on non-conformant preprocessor behavior. This fix avoids warnings and errors from the newer, conformant msvc preprocessor, while still compiling with the traditional, non-conformant msvc preprocessor as well (which as of 2025, remains the default even in the latest msvc version).
I preserved the block comment at the top since I'm assuming you've got SPDX parsing automation that cares about the format of that top header.
There appeared to be a number of other non-functional changes missing from this vendored copy. - updated comments, renamed arguments, and some reordered enum entries (but the actual enum values were explicitly assigned, so there's no functional change), and so on.
I brought those in as well to bring it fully up to date.
CHANGELOG.mdupdated for non-trivial changes - happy to add a line if this change is considered non-trivial.