[CONFIGURATION] File configuration - Tracer/Meter/Logger config#3920
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3920 +/- ##
==========================================
+ Coverage 90.05% 90.13% +0.09%
==========================================
Files 226 227 +1
Lines 7229 7250 +21
==========================================
+ Hits 6509 6534 +25
+ Misses 720 716 -4
🚀 New features to boost your workflow:
|
61e4ad7 to
d71a591
Compare
Implement ExperimentalTracerConfig, ExperimentalTracerConfigurator, ExperimentalTracerMatcherAndConfig and their Meter/Logger equivalents as defined in the declarative configuration spec. - Add 9 new configuration model headers (Config, MatcherAndConfig, Configurator for each signal) - Wire configurator fields into TracerProviderConfiguration, MeterProviderConfiguration, and LoggerProviderConfiguration - Implement YAML parsing for the new configuration types in ConfigurationParser - Add ScopeConfigurator creation with wildcard name matching in SdkBuilder - Add unit tests for parsing the new configurator sections Resolves open-telemetry#3915
d71a591 to
a6ad72d
Compare
sdk/include/opentelemetry/sdk/configuration/meter_config_configuration.h
Show resolved
Hide resolved
marcalff
left a comment
There was a problem hiding this comment.
Nice work, which fits into the existing code.
See preliminary comments.
sdk/include/opentelemetry/sdk/configuration/configuration_parser.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/configuration/experimental_logger_config_configuration.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/configuration/meter_config_configuration.h
Show resolved
Hide resolved
|
Thanks for the PR, it looks good with a few comments to fix. Would you have time to address them ? Looking to merge this. |
|
Hi, @marcalff I have updated code according to comments. Could you please check it out. |
marcalff
left a comment
There was a problem hiding this comment.
Thanks for the patch.
The code itself is spotless, well done.
What remains is the bazel build (we use both CMake and bazel).
900683f to
11a02d3
Compare
11a02d3 to
ecc61ca
Compare
|
Thanks for all the CI fixes, the last change should do it for IWYU. |
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the yaml feature.
Great work.
Fixes #3915
Summary
Implements the file configuration types for Tracer, Meter, and Logger as described in #3915.
Changes
ExperimentalTracerConfig,ExperimentalTracerMatcherAndConfig,ExperimentalTracerConfigurator(and their Meter/Logger equivalents), following the project's one-class-per-header convention.FIXMEcomments inTracerProviderConfiguration,MeterProviderConfiguration, andLoggerProviderConfigurationwith the new configurator fields.tracer_configurator/development,meter_configurator/development, andlogger_configurator/developmentsections inConfigurationParser.CreateTracerConfigurator,CreateMeterConfigurator,CreateLoggerConfiguratorinSdkBuilderto constructScopeConfigurator<T>objects from parsed configuration, including wildcard name matching (?and*).yaml_trace_test.cc,yaml_metrics_test.cc, andyaml_logs_test.cc.Types implemented
Test plan