[cartservice] Record seconds instead of ticks for custom metrics#2135
Merged
puckpuck merged 7 commits intoopen-telemetry:mainfrom Apr 20, 2025
Merged
Conversation
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Kielek
approved these changes
Apr 14, 2025
puckpuck
approved these changes
Apr 17, 2025
rogercoll
approved these changes
Apr 17, 2025
cloud-hb
pushed a commit
to cloud-hb/opentelemetry-demo
that referenced
this pull request
Nov 17, 2025
…n-telemetry#2135) * add unit and record seconds instead of ticks * CHANGELOG * new bucket boundaries --------- Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Change custom app metrics from ticks to seconds and adds units for metrics.
Per the .NET docs,
ElapsedTicks:Uses same bucket boundaries as http.server.request.duration and messaging.client.operation.duration - happy to change this, seemed like a reasonable default.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.