-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update OTLP exporters to use HTTP instead of gRPC #2697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…duct-catalog modules
…K attachment at runtime and remove unnecessary dependencies
…RICS_EXPORTER environment variable
cyrille-leclerc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting working on this.
src/ad/Dockerfile
Outdated
| @@ -1,3 +1,6 @@ | |||
| # run from repo root | |||
| # docker buildx build --platform linux/amd64,linux/arm64 -t appmonitoring.azurecr.io/demo-ad:1.0.0 --push -f ./src/ad/Dockerfile . | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment desired or is it a development thing?
| ARG OTEL_JAVA_AGENT_VERSION | ||
| ARG _JAVA_OPTIONS | ||
| # ARG OTEL_JAVA_AGENT_VERSION | ||
| # ARG _JAVA_OPTIONS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this env var is used by the Docker Compose:
opentelemetry-demo/docker-compose.yml
Lines 50 to 77 in 1e67b60
| ad: | |
| image: ${IMAGE_NAME}:${DEMO_VERSION}-ad | |
| container_name: ad | |
| build: | |
| context: ./ | |
| dockerfile: ${AD_DOCKERFILE} | |
| cache_from: | |
| - ${IMAGE_NAME}:${IMAGE_VERSION}-ad | |
| args: | |
| OTEL_JAVA_AGENT_VERSION: ${OTEL_JAVA_AGENT_VERSION} | |
| deploy: | |
| resources: | |
| limits: | |
| memory: 300M | |
| restart: unless-stopped | |
| ports: | |
| - "${AD_PORT}" | |
| environment: | |
| - AD_PORT | |
| - FLAGD_HOST | |
| - FLAGD_PORT | |
| - OTEL_EXPORTER_OTLP_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_HTTP} | |
| - OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE | |
| - OTEL_RESOURCE_ATTRIBUTES | |
| - OTEL_LOGS_EXPORTER=otlp | |
| - OTEL_SERVICE_NAME=ad | |
| # Workaround on OSX for https://bugs.openjdk.org/browse/JDK-8345296 | |
| - _JAVA_OPTIONS |
| ADD --chmod=644 https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v$OTEL_JAVA_AGENT_VERSION/opentelemetry-javaagent.jar /usr/src/app/opentelemetry-javaagent.jar | ||
| ENV JAVA_TOOL_OPTIONS=-javaagent:/usr/src/app/opentelemetry-javaagent.jar | ||
| # ADD --chmod=644 https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v$OTEL_JAVA_AGENT_VERSION/opentelemetry-javaagent.jar /usr/src/app/opentelemetry-javaagent.jar | ||
| # ENV JAVA_TOOL_OPTIONS=-javaagent:/usr/src/app/opentelemetry-javaagent.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment removing the OTel Java Autoinstr agent from the Docker image? I think we need it
Update OTLP exporters to use HTTP instead of gRPC
Changes
Please provide a brief description of the changes here.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.