Skip to content

Conversation

@maximilianoPizarro
Copy link

@maximilianoPizarro maximilianoPizarro commented Nov 5, 2025

Changes

Please provide a brief description of the changes here.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@maximilianoPizarro maximilianoPizarro requested a review from a team as a code owner November 5, 2025 12:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maximilianoPizarro / name: Maximiliano Pizarro (cc23012, d68091c)

@julianocosta89
Copy link
Member

@maximilianoPizarro thx for that contribution!
Would it be possible to contribute that via https://github.com/open-telemetry/opentelemetry-helm-charts?

This file is generated from the make generate-kubernetes-manifests command.
And this one on its turn is just generating the manifests from the helm chart.

@maximilianoPizarro
Copy link
Author

Hi @julianocosta89 , thanks for the feedback! I've added a YAML file for the OpenShift scenario within the Kubernetes folder, opentelemetry-demo-openshift.yaml. I rolled back the YAML file generated by the make generate-kubernetes-manifests command so they wouldn't overlap for this initial scope. What do you think about saving a version? I'll also be analyzing the integration in the Helm Chart repository. I'd like to add this version as a backup. Have a great week!

@julianocosta89
Copy link
Member

@maximilianoPizarro moving forward with the Demo we have decided that we will not maintain the k8s-manifests anymore.
We will document the way to generate them using helm.

During the last SIG meeting we agreed that we would create a container containing Helm and if the user wants to deploy the Demo without using Helm, he could run make generate-kubernetes-manifests and this command would use the Helm container to generate the k8s manifests.

With that in mind, if we want an OpenShift manifest file, we would need to add it in the Helm chart and then have a param like: make generate-kubernetes-manifests DISTRO=OpenShift or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants