Add Grpc Readiness probe to cart microservice. Failure can be enabled through feature flag to simulate pod not ready situation #2830
Conversation
…ded to enable it in flagd
Adding readiness probe health check to cart service + feature flag ad…
github-actions
bot
added
docs-update-required
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@open-telemetry/demo-approvers can anyone please review this ? |
|
@cedricziel @ps48 can you please review this PR and provide your feedback. This is my first contribution and looking forward to the guidance. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@manojsardana thanks for submitting this PR. |
|
@julianocosta89 i did complete the process of signing multiple times, however its not getting reflected. here. |
|
@julianocosta89 I am able to complete the sign now. Thanks. Looking forward to he review feedback. |
cedricziel
left a comment
cedricziel
left a comment
There was a problem hiding this comment.
@manojsardana generally okay - did you want implement an actual readiness probe or did you want to leave it with the skeleton? also: can you tidy up the code a little bit?
Removed commented-out health check code in Program.cs.
Co-authored-by: Cedric Ziel <[email protected]>
|
@manojsardana thanks for all of this. Can you break out all the Health Check code to a separate file (ie: healthcheck.cs)? |
|
@puckpuck i have update the code to move the healthcheck service under services folder now. Fixed a couple of more things which was failing in the previous build. Let me know if there any further feedback i can address. Thanks for your review and feedback. |
Add missing newline at end of file
julianocosta89
dismissed
cedricziel’s stale review
Changes requested were applied
… through feature flag to simulate pod not ready situation (open-telemetry#2830) * Adding readiness probe health check to cart service + feature flag added to enable it in flagd * Clean up commented health check code Removed commented-out health check code in Program.cs. * Update src/cart/src/Program.cs Co-authored-by: Cedric Ziel <[email protected]> * moving the healthcheck test to a separate file under services folder * Fix missing newline in healthcheck.cs Add missing newline at end of file * Add copyright and license information to healthcheck.cs * changelog --------- Co-authored-by: Manojkumar Sardana <[email protected]> Co-authored-by: Cedric Ziel <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Juliano Costa <[email protected]>
5 participants
Changes
Please provide a brief description of the changes here.
The change add a gRPC healthcheck implementation to cart microservice. The health check respond healthy status by default. However a feature flag is added to enable readiness failure. Once enabled, the the health check will respond with unhealthy status. This will result into pod not ready status and requests to the pod being dropped/timing out. One the feature flag is disabled, the readiness probe will succeed and pod will start accepting the request successfully.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.