Skip to content

Conversation

Kielek
Copy link
Member

@Kielek Kielek commented Jul 17, 2025

Replaces #2919, I needed to make hard cleanup in my fork after some tests

Changes

CONTRIBUTING - update PR with example of new project
the previous one is outdated

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

the previous one is outdated
@Kielek Kielek requested a review from a team as a code owner July 17, 2025 10:50
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 17, 2025
@Kielek Kielek changed the title CONTRIBUTING - update RR with new example CONTRIBUTING - update PR with example of new project Jul 17, 2025
project to the repository. A good example to follow is the pull request which
added the `OpenTelemetry.Resources.OperatingSystem` project:
[#1943](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1943).
added the `OpenTelemetry.OpAmp.Client` project:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call that a bad example as the build consumes over 6hrs of build time & runs over 200 actions hence not efficient. I wouldn't want more projects following that example, hence a better example should be selected.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is about document current state of the implementation. If you see possibility to improve, we are opened for this.
If changes are touch only one project, only small subset of builds is executed. See: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/.github/workflows/ci.yml#L25-L74

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am aware of that massive if etc. If you look at: #2926 you will see what i am seeing as that did a massive run and we are yet to see a case of a non massive run. The only change to a file not in the opamp folder is the removal of a project from the verify-aot step but it still ran a massive long list of actions hence far from efficent. It appears to be simply treating any yaml changes in the github folder as grounds for an entire build, hence lots of room for improvement. I have already put in a PR to adopt modules which detangles responsibility for build process and is all documented.

@Kielek Kielek merged commit 29583fe into open-telemetry:main Jul 21, 2025
55 checks passed
@Kielek Kielek deleted the update-contributing branch July 21, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants