Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenTelemetry.OpAmp.Client/FrameDispatcher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace OpenTelemetry.OpAmp.Client;

internal class FrameDispatcher : IDisposable
internal sealed class FrameDispatcher : IDisposable
{
private readonly IOpAmpTransport transport;
private readonly FrameBuilder frameBuilder;
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.OpAmp.Client/FrameProcessor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace OpenTelemetry.OpAmp.Client;

internal class FrameProcessor
internal sealed class FrameProcessor
{
private readonly ConcurrentDictionary<Type, ImmutableList<IOpAmpListener>> listeners = [];

Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.OpAmp.Client/OpAmpClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace OpenTelemetry.OpAmp.Client;

internal class OpAmpClient
internal sealed class OpAmpClient
{
private readonly OpAmpClientSettings settings = new();
private readonly FrameProcessor processor = new();
Expand Down
7 changes: 6 additions & 1 deletion src/OpenTelemetry.OpAmp.Client/OpAmpClientSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ internal class OpAmpClientSettings
/// <summary>
/// Gets or sets the unique identifier for the current instance.
/// </summary>
public Guid InstanceUid { get; set; } = Guid.NewGuid(); // TODO: use Guid.CreateVersion7() with .NET 9+
public Guid InstanceUid { get; set; }
#if NET9_0_OR_GREATER
= Guid.CreateVersion7();
#else
= Guid.NewGuid();
#endif

/// <summary>
/// Gets or sets the chosen metrics schema to write.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetMinimumSupportedVersion);$(NetStandardMinimumSupportedVersion);$(NetFrameworkMinimumSupportedVersion)</TargetFrameworks>
<TargetFrameworks>$(NetMinimumSupportedVersion);net9.0;$(NetStandardMinimumSupportedVersion);$(NetFrameworkMinimumSupportedVersion)</TargetFrameworks>
<Description>OpAMP Client for OpenTelemetry .NET.</Description>
<PackageTags>$(PackageTags);distributed-tracing;opamp;opamp-client</PackageTags>
<MinVerTagPrefix>OpAmp.Client-</MinVerTagPrefix>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace OpenTelemetry.OpAmp.Client.Transport.Http;

internal class PlainHttpTransport : IOpAmpTransport, IDisposable
internal sealed class PlainHttpTransport : IOpAmpTransport, IDisposable
{
private readonly Uri uri;
private readonly HttpClient httpClient;
Expand Down
Loading