[Infra] Move to Central Package Management #3152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
github-actions
bot
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
==========================================
- Coverage 70.09% 69.91% -0.19%
==========================================
Files 430 440 +10
Lines 16909 16956 +47
==========================================
+ Hits 11853 11855 +2
- Misses 5056 5101 +45 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
github-actions
bot
added
comp:instrumentation.grpccore
github-actions
bot
assigned
g7ed6e,
hananiel,
Havret,
IliaBrahinets,
iskiselev,
Kielek and
lachmatt
martincostello
commented
Oct 1, 2025
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
evgenyfedorov2
approved these changes
Oct 1, 2025
Adopt Central Package Version Management and update syntax for library dependency versions to prepare for adoption of Renovate instead of Dependabot.
Missed from previous commit.
Fix-up dependency versions to (almost) match main.
martincostello
force-pushed
the
renovate-prep
branch
from
5b5136e to
ac86479
Compare
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
martincostello
commented
Oct 1, 2025
Comment on lines
+60
to
+68
| <!-- Version overrides for specific netX.0 TFMs --> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | ||
| <PackageVersion Update="Microsoft.Extensions.Configuration" Version="[8.0.0,)" /> | ||
| <PackageVersion Update="Microsoft.Extensions.Options" Version="[8.0.0,)" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageVersion Update="Microsoft.Extensions.Configuration" Version="[9.0.0,)" /> | ||
| <PackageVersion Update="Microsoft.Extensions.Options" Version="[9.0.0,)" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
To sync with open-telemetry/opentelemetry-dotnet#6327.
Kielek
approved these changes
Oct 7, 2025
src/OpenTelemetry.Exporter.Instana/OpenTelemetry.Exporter.Instana.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.InfluxDB/OpenTelemetry.Exporter.InfluxDB.csproj
Show resolved
Hide resolved
|
In general LGTM. Some minor comments |
Restore comment regarding the System.Net.Http reference, but with more clarity.
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
Restore comments explaining transitive upgrades.
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
Fix lint warning.
martincostello
requested a deployment
to
external
GitHub Actions
Waiting
This was referenced Oct 7, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-telemetry/opentelemetry-dotnet#6539 (comment)
Changes
Adopt Central Package Version Management and update syntax for library dependency versions to prepare for adoption of Renovate instead of Dependabot.
Next week I'll write some throwaway automation to check the dependency versions in main for all the.nupkgfiles then run it again on this PR and compare the output to check there's no differences (or any differences are acceptable).I also need to re-review the changes to the automation workflow that updates the OTel package versions when there's a new release in open-telemetry/opentelemetry-dotnet.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)